[Intel-gfx] [PATCH] drm/i915: Don't set fence errors on non-guilty requests
Daniel Vetter
daniel.vetter at ffwll.ch
Thu Jul 20 20:14:17 UTC 2017
... at least not in that place, because this can also fire for
requests which have completed. Which then hits the assert in
dma_fence_set_error.
Since I'm not really clear what should be done here I pinged Chris,
and he suggested we simply remove this for now.
Found while stress-testing gpu reset using kms_busy, with about 0-3
hits of it per complete run on my snb here.
Testcase: igt/kms_busy.
Cc: Chris Wilson <chris at chris-wilson.co.uk>
Cc: Mika Kuoppala <mika.kuoppala at intel.com>
Cc: Joonas Lahtinen <joonas.lahtinen at linux.intel.com>
Signed-off-by: Daniel Vetter <daniel.vetter at intel.com>
---
drivers/gpu/drm/i915/i915_gem.c | 1 -
1 file changed, 1 deletion(-)
diff --git a/drivers/gpu/drm/i915/i915_gem.c b/drivers/gpu/drm/i915/i915_gem.c
index 1a8842f143fc..1c7453e2cc45 100644
--- a/drivers/gpu/drm/i915/i915_gem.c
+++ b/drivers/gpu/drm/i915/i915_gem.c
@@ -2955,7 +2955,6 @@ static bool i915_gem_reset_request(struct drm_i915_gem_request *request)
skip_request(request);
} else {
i915_gem_context_mark_innocent(request->ctx);
- dma_fence_set_error(&request->fence, -EAGAIN);
}
return guilty;
--
2.13.2
More information about the Intel-gfx
mailing list