[Intel-gfx] [PATCH] drm/i915: Remove unused i915_err_print_instdone

Chris Wilson chris at chris-wilson.co.uk
Thu Jul 27 08:40:17 UTC 2017


Quoting Tvrtko Ursulin (2017-07-27 09:28:05)
> From: Tvrtko Ursulin <tvrtko.ursulin at intel.com>
> 
> Somewhere, sometime, in some refactoring it seems to have been
> left behind with no callers.

commit eaa14c24864ecfc60fb591f3b20747af7c67d446
Author: Chris Wilson <chris at chris-wilson.co.uk>
Date:   Wed Oct 19 13:52:03 2016 +0100

    drm/i915: Stop reporting error details in dmesg as well as the error-state
    
    As we already capture all the information from the registers into the
    error-state, also dumping that to dmesg just generates noise that upsets
    CI and users alike (and doesn't provide us with any more information).

Add a citation that killing off pr_err was deliberate.

> Signed-off-by: Tvrtko Ursulin <tvrtko.ursulin at intel.com>
Reviewed-by: Chris Wilson <chris at chris-wilson.co.uk>
-Chris


More information about the Intel-gfx mailing list