[Intel-gfx] [PATCH 6/6] drm/i915: Add support for CCS modifiers
Daniel Vetter
daniel at ffwll.ch
Mon Jul 31 08:29:55 UTC 2017
On Sat, Jul 29, 2017 at 09:25:50AM -0700, Ben Widawsky wrote:
> On 17-07-29 13:53:10, Daniel Stone wrote:
> > Hi Ben,
> >
> > On 26 July 2017 at 19:08, Ben Widawsky <ben at bwidawsk.net> wrote:
> > > + } else if (INTEL_GEN(dev_priv) >= 9) {
> > > intel_primary_formats = skl_primary_formats;
> > > num_formats = ARRAY_SIZE(skl_primary_formats);
> > > - modifiers = skl_format_modifiers;
> > > + if (pipe >= PIPE_C)
> > > + modifiers = skl_format_modifiers_ccs;
> > > + else
> > > + modifiers = skl_format_modifiers_noccs;
> >
> > Shouldn't that be (pipe < PIPE_C)?
> >
> > Cheers,
> > Daniel
>
> Yep. It was wrong in v7 too :/. I have it fixed locally.
Shouldn't the igt catch this, or does it not try to exercise all the
plane/crtc combos there are?
-Daniel
--
Daniel Vetter
Software Engineer, Intel Corporation
http://blog.ffwll.ch
More information about the Intel-gfx
mailing list