[Intel-gfx] [PATCH] drm/i915/guc: Assert that we switch between known ggtt->invalidate functions

Chris Wilson chris at chris-wilson.co.uk
Thu Jun 1 11:01:19 UTC 2017


On Thu, Jun 01, 2017 at 01:44:07PM +0300, Joonas Lahtinen wrote:
> On to, 2017-06-01 at 10:04 +0100, Chris Wilson wrote:
> > When we enable the GuC, we enable an alternative mechanism for doing
> > post-GGTT update invalidation. Likewise, when we disable the GuC, we
> > restore the previous method. Assert that we change between known
> > endpoints, so that we can catch if we accidentally clobber some other
> > gen and if we change the invalidate routine without updating guc.
> > 
> > Signed-off-by: Chris Wilson <chris at chris-wilson.co.uk>
> > Cc: Tvrtko Ursulin <tvrtko.ursulin at linux.intel.com>
> > Cc: Joonas Lahtinen <joonas.lahtinen at linux.intel.com>
> > Cc: Oscar Mateo <oscar.mateo at intel.com>
> > Cc: Daniele Ceraolo Spurio <daniele.ceraolospurio at intel.com>
> > Cc: Michal Wajdeczko <michal.wajdeczko at intel.com>
> > Cc: Arkadiusz Hiler <arkadiusz.hiler at intel.com>
> > Cc: Michel Thierry <michel.thierry at intel.com>
> 
> This was R-b'd by Michal already, a dup patch?

This is the second step to turn the v4.11 bugfix into a warning that it
never happens again.
-Chris

-- 
Chris Wilson, Intel Open Source Technology Centre


More information about the Intel-gfx mailing list