[Intel-gfx] [PATCH v15 06/14] drm/i915/perf: Add OA unit support for Gen 8+
Chris Wilson
chris at chris-wilson.co.uk
Thu Jun 1 11:48:50 UTC 2017
On Wed, May 31, 2017 at 01:33:47PM +0100, Lionel Landwerlin wrote:
> u32 gen7_latched_oastatus1;
> + u32 ctx_oactxctrl_offset;
> + u32 ctx_flexeu0_offset;
> +
> + /* The RPT_ID/reason field for Gen8+ includes a bit
> + * to determine if the CTX ID in the report is valid
> + * but the specific bit differs between Gen 8 and 9
> + */
This is completely minor, but a coding-style nit nevertheless, can you
go through and make sure all block commments are
/*
* Hello World!
*/
i.e. a blank first line (for symmetry with the blank last apparently),
but it does pay off when mixing normal comment blocks with kerneldoc.
-Chris
--
Chris Wilson, Intel Open Source Technology Centre
More information about the Intel-gfx
mailing list