[Intel-gfx] [PATCH] drm/i915: Remove dead code from runtime resume handler

Vivi, Rodrigo rodrigo.vivi at intel.com
Thu Jun 1 21:08:35 UTC 2017


Reviewed-by: Rodrigo Vivi <rodrigo.vivi at intel.com>

On Thu, 2017-06-01 at 21:30 +0300, ville.syrjala at linux.intel.com wrote:
> From: Ville Syrjälä <ville.syrjala at linux.intel.com>
> 
> Remove the SNB PCH refclock init call from the runtime resume handler.
> I don't think it was actually needed even when we had SNB runtime PM,
> and if definitely isn't needed ever since SNB runtime PM was nuked in
> commit d4c5636e7447 ("drm/i915: Remove runtime PM for SNB").
> 
> Cc: Rodrigo Vivi <rodrigo.vivi at intel.com>
> Cc: Paulo Zanoni <paulo.r.zanoni at intel.com>
> Signed-off-by: Ville Syrjälä <ville.syrjala at linux.intel.com>
> ---
>  drivers/gpu/drm/i915/i915_drv.c | 3 ---
>  1 file changed, 3 deletions(-)
> 
> diff --git a/drivers/gpu/drm/i915/i915_drv.c b/drivers/gpu/drm/i915/i915_drv.c
> index 2fdfaf135ea9..13735bc69c8c 100644
> --- a/drivers/gpu/drm/i915/i915_drv.c
> +++ b/drivers/gpu/drm/i915/i915_drv.c
> @@ -2461,9 +2461,6 @@ static int intel_runtime_resume(struct device *kdev)
>  
>  	intel_guc_resume(dev_priv);
>  
> -	if (IS_GEN6(dev_priv))
> -		intel_init_pch_refclk(dev_priv);
> -
>  	if (IS_GEN9_LP(dev_priv)) {
>  		bxt_disable_dc9(dev_priv);
>  		bxt_display_core_init(dev_priv, true);



More information about the Intel-gfx mailing list