[Intel-gfx] [PATCH 13/13] drm/i915/cfl: Coffe Lake reuses Kabylake DMC.

Pandiyan, Dhinakaran dhinakaran.pandiyan at intel.com
Fri Jun 2 21:49:01 UTC 2017


On Tue, 2017-05-30 at 15:43 -0700, Rodrigo Vivi wrote:
> From the DMC perspective the same firmware is used on
> both platforms. We haven't recieved any separated release
> specifically for Coffee Lake so let's just re-use what
> is already there for Kabylake.
> 
> Signed-off-by: Rodrigo Vivi <rodrigo.vivi at intel.com>

Typo in title, did you mean cofveve? :)

The patch does what it says. With the title fixed,
Reviewed-by: Dhinakaran Pandiyan <dhinakaran.pandiyan at intel.com>

> ---
>  drivers/gpu/drm/i915/i915_pci.c  | 1 +
>  drivers/gpu/drm/i915/intel_csr.c | 4 ++--
>  2 files changed, 3 insertions(+), 2 deletions(-)
> 
> diff --git a/drivers/gpu/drm/i915/i915_pci.c b/drivers/gpu/drm/i915/i915_pci.c
> index 0b1c96d..c1052b8 100644
> --- a/drivers/gpu/drm/i915/i915_pci.c
> +++ b/drivers/gpu/drm/i915/i915_pci.c
> @@ -430,6 +430,7 @@
>  	.is_alpha_support = 1,
>  	.platform = INTEL_COFFEELAKE,
>  	.gen = 9,
> +	.has_csr = 1,
>  	.ddb_size = 896,
>  };
>  
> diff --git a/drivers/gpu/drm/i915/intel_csr.c b/drivers/gpu/drm/i915/intel_csr.c
> index 1575bde..fb6af0b 100644
> --- a/drivers/gpu/drm/i915/intel_csr.c
> +++ b/drivers/gpu/drm/i915/intel_csr.c
> @@ -291,7 +291,7 @@ static uint32_t *parse_csr_fw(struct drm_i915_private *dev_priv,
>  
>  	if (IS_GEMINILAKE(dev_priv)) {
>  		required_version = GLK_CSR_VERSION_REQUIRED;
> -	} else if (IS_KABYLAKE(dev_priv)) {
> +	} else if (IS_KABYLAKE(dev_priv) || IS_COFFEELAKE(dev_priv)) {
>  		required_version = KBL_CSR_VERSION_REQUIRED;
>  	} else if (IS_SKYLAKE(dev_priv)) {
>  		required_version = SKL_CSR_VERSION_REQUIRED;
> @@ -440,7 +440,7 @@ void intel_csr_ucode_init(struct drm_i915_private *dev_priv)
>  
>  	if (IS_GEMINILAKE(dev_priv))
>  		csr->fw_path = I915_CSR_GLK;
> -	else if (IS_KABYLAKE(dev_priv))
> +	else if (IS_KABYLAKE(dev_priv) || IS_COFFEELAKE(dev_priv))
>  		csr->fw_path = I915_CSR_KBL;
>  	else if (IS_SKYLAKE(dev_priv))
>  		csr->fw_path = I915_CSR_SKL;



More information about the Intel-gfx mailing list