[Intel-gfx] [PATCH 1/4] drm/i915: Check signaled state after enabling signaling

[Mika Kuoppala]

Chris Wilson <chris at chris-wilson.co.uk> writes:

> Settting up the irq to signal the request completion takes a finite
      ^-t

Reviewed-by: Mika Kuoppala <mika.kuoppala at intel.com>

> amount of time, during which it is possible that the request already
> completed. Check afterwards, just in case, so that we can respond
> immediately.
>
> Signed-off-by: Chris Wilson <chris at chris-wilson.co.uk>
> Cc: Joonas Lahtinen <joonas.lahtinen at linux.intel.com>
> Cc: Tvrtko Ursulin <tvrtko.ursulin at intel.com>
> ---
>  drivers/gpu/drm/i915/i915_gem_request.c | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/drivers/gpu/drm/i915/i915_gem_request.c b/drivers/gpu/drm/i915/i915_gem_request.c
> index 0d1e0d8873ef..46d869e26b4d 100644
> --- a/drivers/gpu/drm/i915/i915_gem_request.c
> +++ b/drivers/gpu/drm/i915/i915_gem_request.c
> @@ -62,7 +62,7 @@ static bool i915_fence_enable_signaling(struct dma_fence *fence)
>  		return false;
>  
>  	intel_engine_enable_signaling(to_request(fence), true);
> -	return true;
> +	return !i915_fence_signaled(fence);
>  }
>  
>  static signed long i915_fence_wait(struct dma_fence *fence,
> -- 
> 2.11.0
>
> _______________________________________________
> Intel-gfx mailing list
> Intel-gfx at lists.freedesktop.org
> https://lists.freedesktop.org/mailman/listinfo/intel-gfx