[Intel-gfx] [PATCH v2 2/5] ACPI / APEI: Switch to use new generic UUID API

Andy Shevchenko andriy.shevchenko at linux.intel.com
Mon Jun 5 16:19:43 UTC 2017


On Mon, 2017-06-05 at 18:01 +0200, Christoph Hellwig wrote:
> > -		if (!uuid_le_cmp(*(uuid_le *)gdata->section_type,
> > -				 CPER_SEC_PLATFORM_MEM)) {
> > +		if (!guid_equal(sec_type, &CPER_SEC_PLATFORM_MEM))
> > {
> 
> The "!" here seems incorrect.
> 
> >  #ifdef CONFIG_ACPI_APEI_PCIEAER
> > -		else if (!uuid_le_cmp(*(uuid_le *)gdata-
> > >section_type,
> > -				      CPER_SEC_PCIE)) {
> > +		else if (!guid_equal(sec_type, &CPER_SEC_PCIE)) {
> 
> Same here.

Thanks!
Are you going to fixup when applying or better me to send an updated
version?

-- 
Andy Shevchenko <andriy.shevchenko at linux.intel.com>
Intel Finland Oy


More information about the Intel-gfx mailing list