[Intel-gfx] [PATCH v2] drm/i915/guc: Clear enable_guc_loading in case of init failure

Michal Wajdeczko michal.wajdeczko at intel.com
Mon Jun 5 17:20:00 UTC 2017


On Mon, Jun 05, 2017 at 10:12:51AM -0700, Michel Thierry wrote:
> And prevent calling i915_ggtt_disable_guc twice (the first when GuC init
> failed, and the second time during driver unload / intel_uc_fini_hw),
> and hitting the GEM_BUG_ON.
> 
> v2: Clear enable_guc_loading unconditionally (Michal)
>     Make sure guc_free_load_err_log is still called (Daniele)
>     Don't shoot the messenger (Chris)
> 
> Fixes: 3950bf3dbff10 ("drm/i915/guc: Add onion teardown to the GuC
> setup")
> Cc: Chris Wilson <chris at chris-wilson.co.uk>
> Cc: Michal Wajdeczko <michal.wajdeczko at intel.com>
> Cc: Daniele Ceraolo Spurio <daniele.ceraolospurio at intel.com>
> Cc: Joonas Lahtinen <joonas.lahtinen at linux.intel.com>
> Signed-off-by: Michel Thierry <michel.thierry at intel.com>
> ---

Reviewed-by: Michal Wajdeczko <michal.wajdeczko at intel.com>

-Michal


More information about the Intel-gfx mailing list