[Intel-gfx] [PATCH v8 03/20] drm/i915: Modify error handler for per engine hang recovery

Michel Thierry michel.thierry at intel.com
Tue Jun 6 00:40:31 UTC 2017


On 6/4/2017 5:06 AM, Chris Wilson wrote:
> And whilst I'm here, we need to extend I915_PARAM_HAS_GPU_RESET to
> indicate having per-engine resets for the complimentary set of igt.
> -Chris
> 

Something like this?

         case I915_PARAM_HAS_GPU_RESET:
-               value = i915.enable_hangcheck && 
intel_has_gpu_reset(dev_priv);
+               value = i915.enable_hangcheck;
+               if (value)
+                       value = intel_has_reset_engine(dev_priv) ? 2 :
+                               intel_has_gpu_reset(dev_priv) ? 1 : 0;
                 break;

(you'll probably think of a nicer way to do it)

I'm also sending the patch with the changes to support parallel resets, 
some other patches need rebase after this change, but I'm holding on those.

Thanks,


More information about the Intel-gfx mailing list