[Intel-gfx] [PATCH] drm/i915: Remove unecessary PORT3 definition.

[Vivi, Rodrigo]

On Mon, 2017-06-05 at 16:57 -0700, Manasi Navare wrote:
> On Mon, Jun 05, 2017 at 03:12:02PM -0700, Rodrigo Vivi wrote:
> > Let's be picky and just use PICK directly.
> > So we can extend this later without creating
> > a new PORT_X por every new number of ports we
> > have to handle.
> > 
> > Cc: Manasi Navare <manasi.d.navare at intel.com>
> > Signed-off-by: Rodrigo Vivi <rodrigo.vivi at intel.com>
> > ---
> >  drivers/gpu/drm/i915/i915_reg.h | 6 ++----
> >  1 file changed, 2 insertions(+), 4 deletions(-)
> > 
> > diff --git a/drivers/gpu/drm/i915/i915_reg.h b/drivers/gpu/drm/i915/i915_reg.h
> > index 1329420..c3bed89 100644
> > --- a/drivers/gpu/drm/i915/i915_reg.h
> > +++ b/drivers/gpu/drm/i915/i915_reg.h
> > @@ -58,10 +58,8 @@ static inline bool i915_mmio_reg_valid(i915_reg_t reg)
> >  #define _MMIO_TRANS(tran, a, b) _MMIO(_TRANS(tran, a, b))
> >  #define _PORT(port, a, b) ((a) + (port)*((b)-(a)))
> >  #define _MMIO_PORT(port, a, b) _MMIO(_PORT(port, a, b))
> > -#define _PIPE3(pipe, ...) _PICK(pipe, __VA_ARGS__)
> > -#define _MMIO_PIPE3(pipe, a, b, c) _MMIO(_PIPE3(pipe, a, b, c))
> > -#define _PORT3(port, ...) _PICK(port, __VA_ARGS__)
> > -#define _MMIO_PORT3(pipe, a, b, c) _MMIO(_PORT3(pipe, a, b, c))
> > +#define _MMIO_PIPE3(pipe, a, b, c) _MMIO(_PICK(pipe, a, b, c))
> > +#define _MMIO_PORT3(pipe, a, b, c) _MMIO(_PICK(pipe, a, b, c))
> >  #define _PHY3(phy, ...) _PICK(phy, __VA_ARGS__)
> >  #define _MMIO_PHY3(phy, a, b, c) _MMIO(_PHY3(phy, a, b, c))
> >
> 
> Directly using _PICK looks good to me so we need not define
> more macros for different number of ports. 

Does this mean rv-b? :P

> 
> Looks good to me.
> 
> Regards
> Manasi
> 
>   
> > -- 
> > 1.9.1
> >