[Intel-gfx] [PATCH 2/8] drm/i915: Implement .get_format_info() hook for CCS

[Daniel Stone]

Hi Vidya,
I guess you didn't see my submission of this series a couple of weeks
ago, which included some fixes.

On 7 June 2017 at 11:41, Vidya Srinivas <vidya.srinivas at intel.com> wrote:
> Link: https://patchwork.kernel.org/patch/9637253/

The Patchwork link can be dropped when submitting by mail.

> +static const struct drm_format_info ccs_formats[] = {
> +       { .format = DRM_FORMAT_XRGB8888, .depth = 24, .num_planes = 2, .cpp = { 4, 1, }, .hsub = 16, .vsub = 8, },
> +       { .format = DRM_FORMAT_XBGR8888, .depth = 24, .num_planes = 2, .cpp = { 4, 1, }, .hsub = 16, .vsub = 8, },
> +       { .format = DRM_FORMAT_ARGB8888, .depth = 32, .num_planes = 2, .cpp = { 4, 1, }, .hsub = 16, .vsub = 8, },
> +       { .format = DRM_FORMAT_ABGR8888, .depth = 32, .num_planes = 2, .cpp = { 4, 1, }, .hsub = 16, .vsub = 8, },
> +};

This is missing the halign/valign parameters introduced here:
https://lists.freedesktop.org/archives/intel-gfx/2017-May/128740.html

You can see they are used in the version of the patch I submitted:
https://lists.freedesktop.org/archives/intel-gfx/2017-May/128741.html

> diff --git a/include/uapi/drm/drm_fourcc.h b/include/uapi/drm/drm_fourcc.h
> index 55e3010..58ee031 100644
> --- a/include/uapi/drm/drm_fourcc.h
> +++ b/include/uapi/drm/drm_fourcc.h
> @@ -251,6 +251,9 @@
>   */
>  #define I915_FORMAT_MOD_Yf_TILED fourcc_mod_code(INTEL, 3)
>
> +#define I915_FORMAT_MOD_Y_TILED_CCS    fourcc_mod_code(INTEL, 4)
> +#define I915_FORMAT_MOD_Yf_TILED_CCS   fourcc_mod_code(INTEL, 5)

This is missing any kind of comment, which can again be found in my
last submission:
https://lists.freedesktop.org/archives/intel-gfx/2017-May/128741.html

I'd also suggested at the time that Yf_TILED should perhaps be tested
until userspace was able to exercise it properly. I sent Mesa patches
yesterday which were tested on my tree, also using the (still
in-review) atomic branch of Weston to exercise GBM. This showed the
issues with halign/valign in particular. Do you have some userspace
which exercises these formats?

Cheers,
Daniel