[Intel-gfx] [PATCH 1/8] drm/i915: Add render decompression support

Daniel Stone daniel at fooishbar.org
Wed Jun 7 10:52:55 UTC 2017


Hi Vidya,

On 7 June 2017 at 11:41, Vidya Srinivas <vidya.srinivas at intel.com> wrote:
> +       case I915_FORMAT_MOD_Y_TILED_CCS:
> +               if (plane == 1)
> +                       return 128;
> +               /* fall through */
>         case I915_FORMAT_MOD_Y_TILED:
>                 if (IS_GEN2(dev_priv) || HAS_128_BYTE_Y_TILING(dev_priv))
>                         return 128;
>                 else
>                         return 512;
> +       case I915_FORMAT_MOD_Yf_TILED_CCS:
> +               if (plane == 1)
> +                       return 128;
> +               /* fall through */

Applying this patch results in the build failing, because you already
use I915_FORMAT_MOD_Y(f)_TILED_CCS in this patch, but don't add the
definition until much later. Please reorder the patches so this comes
after the definition.

Cheers,
Daniel


More information about the Intel-gfx mailing list