[Intel-gfx] [PATCH igt] lib/kms: Force a full reprobe if we find a bad link

[Lofstedt, Marta]

Martin, the kms_flip test already skips when we have entered the "no modes available" state. 
I talked with Petri a bit about this and we sort of agree that IGT should only skip tests on an "expected" lack of HW/SW requirements. IGT should not skip on bad states that has been created by the test itself or other tests.

/Marta

> -----Original Message-----
> From: Martin Peres [mailto:martin.peres at linux.intel.com]
> Sent: Wednesday, June 7, 2017 2:59 PM
> To: Chris Wilson <chris at chris-wilson.co.uk>; intel-gfx at lists.freedesktop.org;
> Lofstedt, Marta <marta.lofstedt at intel.com>
> Subject: Re: [Intel-gfx] [PATCH igt] lib/kms: Force a full reprobe if we find a
> bad link
> 
> On 07/06/17 14:33, Chris Wilson wrote:
> > Quoting Martin Peres (2017-06-07 12:13:24)
> >> How about this: When the modeset call fails, check if the link-status
> >> is BAD. If not, return a FAIL. If so, force a full re-probe, pick the
> >> highest available mode and try again. Do this until a mode applies.
> >> If no modes are left, just SKIP the test altogether.
> >>
> >> Does this sound reasonable?
> >
> > The problem here is that we need to loop back to the test for it to
> > decide on the next mode. In most cases we don't care, but igt_kms.c
> > doesn't know this. But if e.g. we have a CRC computed for one size, it
> > needs to be swapped out for the new mode.
> 
> Oh dear, isn't life fun?