[Intel-gfx] [PATCH 1/3] drm/i915/cfl: Add Coffee Lake PCI IDs for S Skus.

[Vivi, Rodrigo]

On Wed, 2017-06-07 at 14:23 -0700, Rodrigo Vivi wrote:
> On Wed, 2017-06-07 at 11:24 -0700, Anusha Srivatsa wrote:
> > Add PCI Ids for S Sku following the BSpec.
> > 
> > v2: Remove the unused INTEL_CFL_IDS.(Rodrigo)
> > 
> > Cc: Rodrigo Vivi <rodrigo.vivi at intel.com>
> > Signed-off-by: Anusha Srivatsa <anusha.srivatsa at intel.com>
> > ---
> >  drivers/gpu/drm/i915/i915_pci.c | 1 +
> >  include/drm/i915_pciids.h       | 4 ++++
> >  2 files changed, 5 insertions(+)
> > 
> > diff --git a/drivers/gpu/drm/i915/i915_pci.c b/drivers/gpu/drm/i915/i915_pci.c
> > index d90942c..3980305 100644
> > --- a/drivers/gpu/drm/i915/i915_pci.c
> > +++ b/drivers/gpu/drm/i915/i915_pci.c
> > @@ -491,6 +491,7 @@ static const struct pci_device_id pciidlist[] = {
> >  	INTEL_KBL_GT3_IDS(&intel_kabylake_gt3_info),
> >  	INTEL_KBL_GT4_IDS(&intel_kabylake_gt3_info),
> >  	INTEL_CNL_IDS(&intel_cannonlake_info),
> > +	INTEL_CFL_S_IDS(&intel_coffeelake_info),

ops, besides adding more pci ids please move this above CNL please.

pleases check my rebased versions:
https://patchwork.freedesktop.org/series/25442/


same apply to all 3 patches.


> >  	{0, 0, 0}
> >  };
> >  MODULE_DEVICE_TABLE(pci, pciidlist);
> > diff --git a/include/drm/i915_pciids.h b/include/drm/i915_pciids.h
> > index 7d2696a..5c5699f 100644
> > --- a/include/drm/i915_pciids.h
> > +++ b/include/drm/i915_pciids.h
> > @@ -325,6 +325,10 @@
> >  	INTEL_VGA_DEVICE(0x5926, info), /* ULT GT3 */ \
> >  	INTEL_VGA_DEVICE(0x5927, info) /* ULT GT3 */
> >  
> > +#define INTEL_CFL_S_IDS(info) \
> > +	INTEL_VGA_DEVICE(0x3E90, info), /* SRV GT1 */ \
> > +	INTEL_VGA_DEVICE(0x3E92, info)  /* SRV GT2 */
> 
> you missed 0x3E93 and 0x3E91
> with that in place feel free to include my rv-b
> 
> > +
> >  #define INTEL_KBL_GT4_IDS(info) \
> >  	INTEL_VGA_DEVICE(0x593B, info) /* Halo GT4 */
> >  
>