[Intel-gfx] [PATCH 1/3] drm/i915: Rename i915.panel_use_ssc field to lvds_use_ssc

Chris Wilson chris at chris-wilson.co.uk
Thu Jun 8 20:00:17 UTC 2017


Quoting Michal Wajdeczko (2017-06-08 17:22:40)
> On Thu, Jun 08, 2017 at 07:03:55PM +0300, Ville Syrjälä wrote:
> > On Thu, Jun 08, 2017 at 03:07:32PM +0000, Michal Wajdeczko wrote:
> > > This is the only field from i915_params struct which name does not match
> > > the the name of the param that it is associated with. Lets fix that now
> > > as this will unblock us with further improvements around params defs.
> > 
> > Maybe we should rename the modparam instead since it does affect eDP as
> > well. Thoughts?
> > 
> 
> For me it's fine (and maybe even easier).
> But I'm not sure how "stable" modparams need to be.

Soft. Since it is used to quirk hw behaviour, occasionally upsetting the
apple-cart so that a user files a bug report and we get it added to the
quirk table is a small price to pay in annoyance. If no one notices, the
modparam may have outlived its usefulness.
-Chris


More information about the Intel-gfx mailing list