[Intel-gfx] [PATCH 1/3] drm/i915/cfl: Add Coffee Lake PCI IDs for S Skus.

Vivi, Rodrigo rodrigo.vivi at intel.com
Thu Jun 8 23:50:24 UTC 2017


On Thu, 2017-06-08 at 16:41 -0700, Anusha Srivatsa wrote:
> Add PCI Ids for S Sku following the BSpec.
> 
> v2: Remove the unused INTEL_CFL_IDS.(Rodrigo)
> v3: Add missing IDs(Rodrigo)
> 
> Cc: Rodrigo Vivi <rodrigo.vivi at intel.com>
> Signed-off-by: Anusha Srivatsa <anusha.srivatsa at intel.com>
> ---
>  drivers/gpu/drm/i915/i915_pci.c | 1 +
>  include/drm/i915_pciids.h       | 8 ++++++++
>  2 files changed, 9 insertions(+)
> 
> diff --git a/drivers/gpu/drm/i915/i915_pci.c b/drivers/gpu/drm/i915/i915_pci.c
> index 03a495e..544b3a5 100644
> --- a/drivers/gpu/drm/i915/i915_pci.c
> +++ b/drivers/gpu/drm/i915/i915_pci.c
> @@ -490,6 +490,7 @@ static const struct pci_device_id pciidlist[] = {
>  	INTEL_KBL_GT2_IDS(&intel_kabylake_info),
>  	INTEL_KBL_GT3_IDS(&intel_kabylake_gt3_info),
>  	INTEL_KBL_GT4_IDS(&intel_kabylake_gt3_info),
> +	INTEL_CFL_S_IDS(&intel_coffeelake_info),
>  	INTEL_CNL_IDS(&intel_cannonlake_info),
>  	{0, 0, 0}
>  };
> diff --git a/include/drm/i915_pciids.h b/include/drm/i915_pciids.h
> index 7d2696a..4858deb 100644
> --- a/include/drm/i915_pciids.h
> +++ b/include/drm/i915_pciids.h
> @@ -334,6 +334,14 @@
>  	INTEL_KBL_GT3_IDS(info), \
>  	INTEL_KBL_GT4_IDS(info)
>  
> +/* CFL S */
> +#define INTEL_CFL_S_IDS(info) \
> +	INTEL_VGA_DEVICE(0x3E90, info), /* SRV GT1 */ \
> +	INTEL_VGA_DEVICE(0x3E93, info), /* SRV GT1 */ \
> +	INTEL_VGA_DEVICE(0x3E91, info), /* SRV GT2 */ \
> +	INTEL_VGA_DEVICE(0x3E92, info), /* SRV GT2 */ \
> +	INTEL_VGA_DEVICE(0x3E96, info)  /* SRV GT2 */

let's merge before they add some more hehehe :)

our process include a review during PV cycle, so we will be fine with
later changes.

Reviewed-by: Rodrigo Vivi <rodrigo.vivi at intel.com>


> +
>  /* CNL U 2+2 */
>  #define INTEL_CNL_U_GT2_IDS(info) \
>  	INTEL_VGA_DEVICE(0x5A52, info), \



More information about the Intel-gfx mailing list