[Intel-gfx] [PATCH IGT] tests/chamelium: Close DRM file descriptor after tests

Arkadiusz Hiler arkadiusz.hiler at intel.com
Tue Jun 13 12:30:43 UTC 2017


On Mon, Jun 12, 2017 at 06:21:45PM +0300, Paul Kocialkowski wrote:
> On Mon, 2017-06-12 at 17:39 +0300, Paul Kocialkowski wrote:
> > This adds a call to close the DRM file descriptor. It is reauired as IGT
> > will attempt to become DRM master after running the test, resulting in a
> > failure.
> 
> This should fix (at least) 3 of the failures seen on the CI machine that runs
> chamelium tests.

Hey Paul,

I've pushed the patch with

Reviewed-by: Arkadiusz Hiler <arkadiusz.hiler at intel.com>

For future patches please adhere to instructions from CONTRIBUTING file:

  Please use --subject-prefix="PATCH i-g-t" so that i-g-t patches are easily
  identified in the massive amount mails on intel-gfx. To ensure this is always
  done, autogen.sh will run:

    git config format.subjectprefix "PATCH i-g-t"

  on its first invocation.

Otherwise patchwork won't pick up the series and it may slip through my
search filters.

Thanks!

-- 
Cheers,
Arek

> 
> > Signed-off-by: Paul Kocialkowski <paul.kocialkowski at linux.intel.com>
> > ---
> >  tests/chamelium.c | 4 ++++
> >  1 file changed, 4 insertions(+)
> > 
> > diff --git a/tests/chamelium.c b/tests/chamelium.c
> > index acd17886..bd7772f8 100644
> > --- a/tests/chamelium.c
> > +++ b/tests/chamelium.c
> > @@ -749,4 +749,8 @@ igt_main
> >  		connector_subtest("vga-hpd-without-ddc", VGA)
> >  			test_hpd_without_ddc(&data, port);
> >  	}
> > +
> > +	igt_fixture {
> > +		close(data.drm_fd);
> > +	}
> >  }
> -- 
> Paul Kocialkowski <paul.kocialkowski at linux.intel.com>
> Intel Finland Oy - BIC 0357606-4 - Westendinkatu 7, 02160 Espoo


More information about the Intel-gfx mailing list