[Intel-gfx] [PATCH] drm/i915: Make i915_vma_destroy() static

Tvrtko Ursulin tvrtko.ursulin at linux.intel.com
Fri Jun 16 13:00:15 UTC 2017


On 16/06/2017 13:35, Chris Wilson wrote:
> i915_vma_destroy() is now not used outside of i915_vma.c so we can
> remove the export and make the function static.
> 
> Signed-off-by: Chris Wilson <chris at chris-wilson.co.uk>
> Cc: Tvrtko Ursulin <tvrtko.ursulin at linux.intel.com>
> ---
>   drivers/gpu/drm/i915/i915_vma.c | 2 +-
>   drivers/gpu/drm/i915/i915_vma.h | 1 -
>   2 files changed, 1 insertion(+), 2 deletions(-)
> 
> diff --git a/drivers/gpu/drm/i915/i915_vma.c b/drivers/gpu/drm/i915/i915_vma.c
> index aa4f98e33951..74e48e3459b3 100644
> --- a/drivers/gpu/drm/i915/i915_vma.c
> +++ b/drivers/gpu/drm/i915/i915_vma.c
> @@ -602,7 +602,7 @@ int __i915_vma_do_pin(struct i915_vma *vma,
>   	return ret;
>   }
>   
> -void i915_vma_destroy(struct i915_vma *vma)
> +static void i915_vma_destroy(struct i915_vma *vma)
>   {
>   	GEM_BUG_ON(vma->node.allocated);
>   	GEM_BUG_ON(i915_vma_is_active(vma));
> diff --git a/drivers/gpu/drm/i915/i915_vma.h b/drivers/gpu/drm/i915/i915_vma.h
> index 36014894400a..d9e52f76cd07 100644
> --- a/drivers/gpu/drm/i915/i915_vma.h
> +++ b/drivers/gpu/drm/i915/i915_vma.h
> @@ -236,7 +236,6 @@ bool i915_vma_misplaced(const struct i915_vma *vma,
>   void __i915_vma_set_map_and_fenceable(struct i915_vma *vma);
>   int __must_check i915_vma_unbind(struct i915_vma *vma);
>   void i915_vma_close(struct i915_vma *vma);
> -void i915_vma_destroy(struct i915_vma *vma);
>   
>   int __i915_vma_do_pin(struct i915_vma *vma,
>   		      u64 size, u64 alignment, u64 flags);
> 

Reviewed-by: Tvrtko Ursulin <tvrtko.ursulin at intel.com>

Regards,

Tvrtko


More information about the Intel-gfx mailing list