[Intel-gfx] [PATCH i-g-t 21/29] igt/perf: make stream_fd a global variable

Lionel Landwerlin lionel.g.landwerlin at intel.com
Fri Jun 16 14:46:18 UTC 2017


On 16/06/17 15:43, Matthew Auld wrote:
> On 25 April 2017 at 23:32, Lionel Landwerlin
> <lionel.g.landwerlin at intel.com> wrote:
>> When debugging unstable tests on new platforms we currently we don't
> we don't currently
>
>> cleanup everything well in between different tests. Since only a
>> single OA stream fd can be opened at a time, having the stream_fd as a
>> global variable helps us cleanup the state between tests.
>>
>> Signed-off-by: Lionel Landwerlin <lionel.g.landwerlin at intel.com>
> So just improve the tests such that they do the necessary cleanup?

That prevents every single test to implement clean logic. That logic is 
abstracted in the open() close instead which is used by most tests.

>
> But if you feel this is better, then:
>
> Reviewed-by: Matthew Auld <matthew.auld at intel.com>
>



More information about the Intel-gfx mailing list