[Intel-gfx] [PATCH 07/19] drm/i915: pass the vma to insert_entries

Chris Wilson chris at chris-wilson.co.uk
Wed Jun 21 21:39:22 UTC 2017


Quoting Matthew Auld (2017-06-21 21:33:33)
> The vma contains most of the information we need for insertion. But also
> in preparation for supporting huge-pages for the ppgtt, it would be
> useful to know the details of vma->page_sizes and the node size, such
> that we can we can easily determine the page sizes we are allowed to use
> when inserting into the 48b PPGTT.  This is especially true for 64K
> where we can't just arbitrarily use it, since we require
> aligning/padding the vm space to 2M, which sometimes we can't enforce in
> the upper levels.
> 
> Suggested-by: Chris Wilson <chris at chris-wilson.co.uk>
> Signed-off-by: Matthew Auld <matthew.auld at intel.com>
> Cc: Joonas Lahtinen <joonas.lahtinen at linux.intel.com>

Reviewed-by: Chris Wilson <chris at chris-wilson.co.uk>

We can apply this immediately, right? (Just resend by itself before you
do.)
-Chris


More information about the Intel-gfx mailing list