[Intel-gfx] [PATCH 16/17] drm/i915: Extract PIPESTAT irq handling into separate functions

Chris Wilson chris at chris-wilson.co.uk
Thu Jun 22 12:55:30 UTC 2017


Quoting ville.syrjala at linux.intel.com (2017-06-22 12:55:54)
> From: Ville Syrjälä <ville.syrjala at linux.intel.com>
> 
> Extract the gen2-4 PIPESTAT irq handling into separate functions just
> like we already do on VLV/CHV.
> 
> We can share valleyview_pipestat_irq_ack() on all gmch platforms to
> actually read and clear the PIPESTAT status bits, so let's rename
> it to i9xx_pipestat_irq_ack().
> 
> Signed-off-by: Ville Syrjälä <ville.syrjala at linux.intel.com>

The code reduction is worth it.
Reviewed-by: Chris Wilson <chris at chris-wilson.co.uk>

Just reminds me that I still want to reduce the workload on chv where we
check for display underruns after every batch.
-Chris


More information about the Intel-gfx mailing list