[Intel-gfx] [kbuild-all] [RFC PATCH drm-intel] drm: arcpgu: arc_pgu_crtc_mode_valid() can be static

[Fengguang Wu]

Hi Daniel,

On Fri, Jun 23, 2017 at 12:30:17PM +0200, Daniel Vetter wrote:
>On Fri, Jun 23, 2017 at 05:54:18PM +0800, kbuild test robot wrote:
>>
>> Signed-off-by: Fengguang Wu <fengguang.wu at intel.com>
>
>Oops, missed that, applied.
>
>Btw, for regression fixes like that, could you perhaps auto-generate the
>Fixes: line per the kernel process? Makes it easier for me to know where
>to apply something :-)

That's a good idea for commits in mainline, where the Fixes tag will
look like

        Fixes: e21d2170f366 ("video: remove unnecessary platform_set_drvdata()")

However typically 0day auto-generated patches are pre-mainline ones,
in which case only patch subject is available. How are we going to
deal with this?

Thanks,
Fengguang

>> ---
>>  arcpgu_crtc.c |    4 ++--
>>  1 file changed, 2 insertions(+), 2 deletions(-)
>>
>> diff --git a/drivers/gpu/drm/arc/arcpgu_crtc.c b/drivers/gpu/drm/arc/arcpgu_crtc.c
>> index 99fbdae..611af74 100644
>> --- a/drivers/gpu/drm/arc/arcpgu_crtc.c
>> +++ b/drivers/gpu/drm/arc/arcpgu_crtc.c
>> @@ -64,8 +64,8 @@ static const struct drm_crtc_funcs arc_pgu_crtc_funcs = {
>>  	.atomic_destroy_state = drm_atomic_helper_crtc_destroy_state,
>>  };
>>
>> -enum drm_mode_status arc_pgu_crtc_mode_valid(struct drm_crtc *crtc,
>> -					     const struct drm_display_mode *mode)
>> +static enum drm_mode_status arc_pgu_crtc_mode_valid(struct drm_crtc *crtc,
>> +						    const struct drm_display_mode *mode)
>>  {
>>  	struct arcpgu_drm_private *arcpgu = crtc_to_arcpgu_priv(crtc);
>>  	long rate, clk_rate = mode->clock * 1000;
>
>-- 
>Daniel Vetter
>Software Engineer, Intel Corporation
>http://blog.ffwll.ch
>_______________________________________________
>kbuild-all mailing list
>kbuild-all at lists.01.org
>https://lists.01.org/mailman/listinfo/kbuild-all