[Intel-gfx] [RESEND i-g-t 1/3] lib/cfl: Add Coffeelake PCI IDs for S SKU.

[Srivatsa, Anusha]

>-----Original Message-----
>From: Hiler, Arkadiusz
>Sent: Wednesday, June 28, 2017 5:20 AM
>To: Srivatsa, Anusha <anusha.srivatsa at intel.com>
>Cc: intel-gfx at lists.freedesktop.org; Vivi, Rodrigo <rodrigo.vivi at intel.com>
>Subject: Re: [Intel-gfx] [RESEND i-g-t 1/3] lib/cfl: Add Coffeelake PCI IDs for S
>SKU.
>
>On Wed, Jun 28, 2017 at 03:17:00PM +0300, Arkadiusz Hiler wrote:
>> On Thu, Jun 22, 2017 at 09:28:35AM -0700, Anusha Srivatsa wrote:
>> > From: anushasr <anusha.srivatsa at intel.com>
>> >
>> > Just following the spec and adding these extra IDs.
>> >
>> > v2: update IDs following the kernel commit:
>> > b056f8f3d6b900e8afd19f312719160346d263b4 (Chris)
>> >
>> > Cc: Rodrigo Vivi <rodrigo.vivi at intel.com>
>> > Signed-off-by: Anusha Srivatsa <anusha.srivatsa at intel.com>
>> > Reviewed-by: Clint Taylor <clinton.a.taylor at intel.com>
>> > ---
>> >  lib/i915_pciids.h       | 10 ++++++++++
>> >  lib/intel_device_info.c |  2 ++
>> >  2 files changed, 12 insertions(+)
>> >
>> > diff --git a/lib/i915_pciids.h b/lib/i915_pciids.h index
>> > 27e0dba..02f43d9 100644
>> > --- a/lib/i915_pciids.h
>> > +++ b/lib/i915_pciids.h
>> > @@ -334,4 +334,14 @@
>> >  	INTEL_KBL_GT3_IDS(info), \
>> >  	INTEL_KBL_GT4_IDS(info)
>> >
>> > +#define INTEL_CFL_S_IDS(info) \
>> > +	INTEL_VGA_DEVICE(0x3E90, info), /* SRV GT1 */ \
>> > +	INTEL_VGA_DEVICE(0x3E93, info), /* SRV GT1 */ \
>> > +	INTEL_VGA_DEVICE(0x3E91, info), /* SRV GT2 */ \
>> > +	INTEL_VGA_DEVICE(0x3E92, info), /* SRV GT2 */ \
>> > +	INTEL_VGA_DEVICE(0x3E96, info) /* SRV GT2 */
>> > +
>> > +#define INTEL_CFL_IDS(info) \
>> > +	INTEL_CFL_S_IDS(info)
>> > +
>> >  #endif /* _I915_PCIIDS_H */
>> > diff --git a/lib/intel_device_info.c b/lib/intel_device_info.c index
>> > 199fa2d..2c46aba 100644
>> > --- a/lib/intel_device_info.c
>> > +++ b/lib/intel_device_info.c
>> > @@ -241,6 +241,8 @@ static const struct pci_id_match
>> > intel_device_match[] = {
>> >
>> >  	INTEL_GLK_IDS(&intel_geminilake_info),
>> >
>> > +	INTEL_CFL_IDS(&intel_coffeelake_info),
>
>Cut the important part accidentally before sending. Here it is:
>
>Hey,
>
>The series does not compile and intel_coffeelake_info is nowhere to be found.
>
>Maybe you are missing a patch from the series?

Intel_coffeelake_info is part of "Introduce Coffeelake platform definition" - 8c47cc5eca.... authored by Rodrigo Vivi.

Once that patch is merged, this one compiles. I thought its already merged. 

I need to send the patches with correct authorship anyway, will check again Arek. 

Thanks ,
Anusha

>> BTW, having
>> "From: anushasr <anusha.srivatsa at intel.com>"
>> on your patches resulting in quite unusual authorship lines.
>>
>> Please consider using `git config --global user.name "Your Full Name"`
>> on the machines you are creating the patches with if this is not
>> intentional.
>>
>> --
>> Cheers,
>> Arek