[Intel-gfx] [PATCH 5/5] drm/i915/cnl: Fix comment about AUX IO power well enable/disable

[Rodrigo Vivi]

Reviewed-by: Rodrigo Vivi <rodrigo.vivi at intel.com>



On Thu, Jun 29, 2017 at 8:37 AM, Imre Deak <imre.deak at intel.com> wrote:
> The comments match an earlier version of the patch, fix them to match
> the current state.
>
> Signed-off-by: Imre Deak <imre.deak at intel.com>
> ---
>  drivers/gpu/drm/i915/intel_runtime_pm.c | 11 +++++++++--
>  1 file changed, 9 insertions(+), 2 deletions(-)
>
> diff --git a/drivers/gpu/drm/i915/intel_runtime_pm.c b/drivers/gpu/drm/i915/intel_runtime_pm.c
> index 2fe715b..5eb9c5e 100644
> --- a/drivers/gpu/drm/i915/intel_runtime_pm.c
> +++ b/drivers/gpu/drm/i915/intel_runtime_pm.c
> @@ -2845,7 +2845,10 @@ static void cnl_display_core_init(struct drm_i915_private *dev_priv, bool resume
>         val |= CL_POWER_DOWN_ENABLE;
>         I915_WRITE(CNL_PORT_CL1CM_DW5, val);
>
> -       /* 4. Enable Power Well 1 (PG1) and Aux IO Power */
> +       /*
> +        * 4. Enable Power Well 1 (PG1).
> +        *    The AUX IO power wells will be enabled on demand.
> +        */
>         mutex_lock(&power_domains->lock);
>         well = lookup_power_well(dev_priv, SKL_DISP_PW_1);
>         intel_power_well_enable(dev_priv, well);
> @@ -2877,7 +2880,11 @@ static void cnl_display_core_uninit(struct drm_i915_private *dev_priv)
>         /* 3. Disable CD clock */
>         cnl_uninit_cdclk(dev_priv);
>
> -       /* 4. Disable Power Well 1 (PG1) and Aux IO Power */
> +       /*
> +        * 4. Disable Power Well 1 (PG1).
> +        *    The AUX IO power wells are toggled on demand, so they are already
> +        *    disabled at this point.
> +        */
>         mutex_lock(&power_domains->lock);
>         well = lookup_power_well(dev_priv, SKL_DISP_PW_1);
>         intel_power_well_disable(dev_priv, well);
> --
> 2.7.4
>
> _______________________________________________
> Intel-gfx mailing list
> Intel-gfx at lists.freedesktop.org
> https://lists.freedesktop.org/mailman/listinfo/intel-gfx



-- 
Rodrigo Vivi
Blog: http://blog.vivi.eng.br