[Intel-gfx] [PATCH] drm/i915: Move bxt exclusive workarounds from gen9 func to bxt one.

Jani Nikula jani.nikula at linux.intel.com
Fri Mar 3 15:37:45 UTC 2017


On Fri, 03 Mar 2017, Imre Deak <imre.deak at intel.com> wrote:
> On Thu, Mar 02, 2017 at 08:27:28PM +0000, Vivi, Rodrigo wrote:
>> On Thu, 2017-03-02 at 21:20 +0200, Ville Syrjälä wrote:
>> > On Thu, Mar 02, 2017 at 11:15:29AM -0800, Rodrigo Vivi wrote:
>> > > +	/* WaDisableDgMirrorFixInHalfSliceChicken5:bxt */
>> > > +	if (IS_BXT_REVID(dev_priv, 0, BXT_REVID_A1))
>> > 
>> > Hmm. I thought someone had already nuked all BXT pre-production
>> > workarounds. I wonder why these still exist...
>> 
>> Well, now that they are organized by the REVID I believe it doesn't hurt
>> to keep them here. In case someone internally end up using a pre-prod
>> hardware for something...
>
> This won't work anyway, since we removed the rest of the BTX pre-prod WAs.
>
>> or for future reference when adding next platforms.
>
> No strong opinion on this, but we removed the pre-prod WAs on other
> platforms too. I'd follow the rule not to keep any unused code around,
> it can be found from git if needed.

Strong opinion, nuke 'em. When there's production hardware available,
pretending to support early steppings is a waste of time.

BR,
Jani.


-- 
Jani Nikula, Intel Open Source Technology Center


More information about the Intel-gfx mailing list