[Intel-gfx] [PATCH 1/4 v3] drm/i915/guc: Keep the ctx_pool_vaddr mapped, for easy access

Oscar Mateo oscar.mateo at intel.com
Fri Mar 3 16:44:58 UTC 2017


On 03/02/2017 02:41 AM, Joonas Lahtinen wrote:
> On pe, 2017-02-24 at 06:01 -0800, Oscar Mateo wrote:
>> The GuC descriptor is big in size. If we use a local definition of
>> guc_desc we have a chance to overflow stack, so avoid it.
>>
>> Also, Chris abhors scatterlists :)
>>
>> v2: Rebased, helper function to retrieve the context descriptor,
>> s/ctx_pool_vma/ctx_pool/
>>
>> v3: Zero out guc_context_desc before initialization
>>
>> Cc: Daniele Ceraolo Spurio <daniele.ceraolospurio at intel.com>
>> Cc: Joonas Lahtinen <joonas.lahtinen at linux.intel.com>
>> Signed-off-by: Oscar Mateo <oscar.mateo at intel.com>
>> Reviewed-by: Chris Wilson <chris at chris-wilson.co.uk>
> Reviewed-by: Joonas Lahtinen <joonas.lahtinen at linux.intel.com>
>
> The first three patches would be rather ready for merging, right?
>
> Regards, Joonas
Hmmmm... not really :(
They sit on top of your patch with the reworked doorbells, so there will 
be merge conflicts. Also, your comment regarding the log extras really 
belongs to the third patch (and while playing with GuC I have found 
another problem with this third patch).
I believe I'll meet you IRL/AFK, so we can agree on a merge strategy 
then :)


More information about the Intel-gfx mailing list