[Intel-gfx] [PATCH 2/3] drm/i915: Wake up all waiters before idling

Chris Wilson chris at chris-wilson.co.uk
Mon Mar 6 13:47:24 UTC 2017


On Mon, Mar 06, 2017 at 11:02:03AM +0000, Chris Wilson wrote:
> On Mon, Mar 06, 2017 at 09:29:15AM +0000, Chris Wilson wrote:
> >  void intel_engine_disarm_breadcrumbs(struct intel_engine_cs *engine)
> >  {
> >  	struct intel_breadcrumbs *b = &engine->breadcrumbs;
> > -	unsigned long flags;
> > +	struct intel_wait *wait, *n;
> >  
> >  	if (!b->irq_armed)
> >  		return;
> >  
> > -	spin_lock_irqsave(&b->irq_lock, flags);
> > -
> >  	/* We only disarm the irq when we are idle (all requests completed),
> >  	 * so if there remains a sleeping waiter, it missed the request
> 
> *so if the bottom-half remains asleep, it missed the request
> 
> Reviewed-by: Mika Kuoppala <mika.kuoppala at intel.com>

Pushed this patch as it should prevent some of the sporadic oopses in
CI.
-Chris

-- 
Chris Wilson, Intel Open Source Technology Centre


More information about the Intel-gfx mailing list