[Intel-gfx] [PATCH 3/3] drm/i915: No need to save/restore irq status in intel_engine_wakeup

Chris Wilson chris at chris-wilson.co.uk
Mon Mar 6 15:11:47 UTC 2017


On Mon, Mar 06, 2017 at 03:03:21PM +0000, Tvrtko Ursulin wrote:
> From: Tvrtko Ursulin <tvrtko.ursulin at intel.com>
> 
> It is called from either the process or timer context so it is
> correct to always disable interrupts.
> 
> Signed-off-by: Tvrtko Ursulin <tvrtko.ursulin at intel.com>
> Cc: Chris Wilson <chris at chris-wilson.co.uk>

All 3 look ok to me, I was uncertain about the timer context allowing
just a spin_lock_irq, but if lockdep is happy I was overly conservation.

Reviewed-by: Chris Wilson <chris at chris-wilson.co.uk>
-Chris

-- 
Chris Wilson, Intel Open Source Technology Centre


More information about the Intel-gfx mailing list