[Intel-gfx] [PATCH 1/1] drm/i915: Initialize pm_intr_keep during intel_irq_init for GuC

Chris Wilson chris at chris-wilson.co.uk
Thu Mar 9 12:35:11 UTC 2017


On Tue, Mar 07, 2017 at 10:22:35AM +0530, Sagar Arun Kamble wrote:
> Driver needs to ensure that it doesn't mask the PM interrupts, which are
> unmasked/needed by GuC firmware. For that, Driver maintains a bitmask of
> interrupts to be kept unmasked, pm_intr_keep.
> 
> pm_intr_keep was determined across GuC load. GuC gets loaded in different
> scenarios and it is not going to change the pm_intr_keep so this patch
> moves its setup to intel_irq_init.
> 
> This patch fixes incorrect RPS masking leading to UP interrupts triggered
> even when at cur_freq=max and inversly for Down interrupts.
> 
> Cc: Radoslaw Szwichtenberg <radoslaw.szwichtenberg at intel.com>
> Cc: Arkadiusz Hiler <arkadiusz.hiler at intel.com>
> Cc: Michal Wajdeczko <michal.wajdeczko at intel.com>
> Cc: Michal Winiarski <michal.winiarski at intel.com>
> Cc: Daniele Ceraolo Spurio <daniele.ceraolospurio at intel.com>
> Signed-off-by: Sagar Arun Kamble <sagar.a.kamble at intel.com>
> Reviewed-by: Chris Wilson <chris at chris-wilson.co.uk>

CI is having issues with guc on bxt, but pushed. Thanks,
-Chris

-- 
Chris Wilson, Intel Open Source Technology Centre


More information about the Intel-gfx mailing list