[Intel-gfx] [PATCH 0/8] Collect command stream based OA reports using i915 perf

[Robert Bragg]

On Thu, Mar 16, 2017 at 6:14 AM,  <sourab.gupta at intel.com> wrote:
> From: Sourab Gupta <sourab.gupta at intel.com>
>
> This series adds framework for collection of OA reports associated with the
> render command stream, which are collected around batchbuffer boundaries.
>
> Refloating the series rebased on Robert's latest patch set for
> 'Enabling OA unit for Gen 8 and 9 in i915 perf', which can be found here:
> https://patchwork.freedesktop.org/series/20084/
>
> Since Robert's patches are being reviewed and this patch series extends his
> framework to collect command stream based OA metrics, it would be good to keep
> this work in perspective. Looking to receive feedback (and possibly r-b's :))
> on the series.
>
> Since the OA reports collected associated with the render command stream, this
> also gives us the ability to collect other metadata such as ctx_id, pid, etc.
> with the samples, and thus we can establish the association of samples
> collected with the corresponding process/workload.
>
> These patches can be found for viewing at
> https://github.com/sourabgu/linux/tree/oa-6march2017
>
> Sourab Gupta (8):
>   drm/i915: Add ctx getparam ioctl parameter to retrieve ctx unique id
>   drm/i915: Expose OA sample source to userspace
>   drm/i915: Framework for capturing command stream based OA reports
>   drm/i915: flush periodic samples, in case of no pending CS sample
>     requests
>   drm/i915: Inform userspace about command stream OA buf overflow
>   drm/i915: Populate ctx ID for periodic OA reports
>   drm/i915: Add support for having pid output with OA report
>   drm/i915: Add support for emitting execbuffer tags through OA counter
>     reports

Thanks for the updated series Sourab.

I think it could really help to have a pointer to some userspace that
can be used to exercise these new features. Maybe you could look at
adding support to the gputop-csv command line tool which is probably
the simplest, usable userspace for i915 perf we have currently. A
pointer to some work-in-progress IGT tests could be good too.

Br,
- Robert

>
>  drivers/gpu/drm/i915/i915_drv.h            |  125 ++-
>  drivers/gpu/drm/i915/i915_gem_context.c    |    3 +
>  drivers/gpu/drm/i915/i915_gem_execbuffer.c |    6 +
>  drivers/gpu/drm/i915/i915_perf.c           | 1149 ++++++++++++++++++++++++----
>  include/uapi/drm/i915_drm.h                |   49 ++
>  5 files changed, 1184 insertions(+), 148 deletions(-)
>
> --
> 1.9.1
>