[Intel-gfx] [03/11 v3] drm/i915/guc: Add onion teardown to the GuC setup
Joonas Lahtinen
joonas.lahtinen at linux.intel.com
Thu Mar 16 13:04:32 UTC 2017
On pe, 2017-03-10 at 08:28 -0800, Oscar Mateo wrote:
> Starting with intel_guc_loader, down to intel_guc_submission
> and finally to intel_guc_log.
>
> v2:
> - Null execbuf client outside guc_client_free (Daniele)
> - Assert if things try to get allocated twice (Daniele/Joonas)
> - Null guc->log.buf_addr when destroyed (Daniele)
> - Newline between returning success and error labels (Joonas)
> - Remove some unnecessary comments (Joonas)
> - Keep guc_log_create_extras naming convention (Joonas)
> - Helper function guc_log_has_extras (Joonas)
> - No need for separate relay_channel create/destroy. It's just another extra.
> - No need to nullify guc->log.flush_wq when destroyed (Joonas)
> - Hoist the check for has_extras out of guc_log_create_extras (Joonas)
> - Try to do i915_guc_log_register/unregister calls (kind of) symmetric (Daniele)
> - Make sure initel_guc_fini is not called before init is ever called (Daniele)
>
> v3:
> - Remove unnecessary parenthesis (Joonas)
> - Check for logs enabled on debugfs registration
> - Rebase on top of Tvrtko's "Fix request re-submission after reset"
>
> Cc: Daniele Ceraolo Spurio <daniele.ceraolospurio at intel.com>
> Cc: Joonas Lahtinen <joonas.lahtinen at linux.intel.com>
> Signed-off-by: Oscar Mateo <oscar.mateo at intel.com>
Drop comments around the interrupt enabling/disabling that log is
currently the only interrupt user.
Reviewed-by: Joonas Lahtinen <joonas.lahtinen at linux.intel.com>
Regards, Joonas
--
Joonas Lahtinen
Open Source Technology Center
Intel Corporation
More information about the Intel-gfx
mailing list