[Intel-gfx] [dim PATCH 07/10] dim: add double quotes to prevent glob interpretation

Jani Nikula jani.nikula at intel.com
Fri Mar 17 10:42:58 UTC 2017


Fix shellcheck SC2053: Quote the rhs of = in [[ ]] to prevent glob
interpretation.

Signed-off-by: Jani Nikula <jani.nikula at intel.com>
---
 Makefile | 1 -
 dim      | 2 +-
 2 files changed, 1 insertion(+), 2 deletions(-)

diff --git a/Makefile b/Makefile
index 94ec71126223..e6fa119d8f44 100644
--- a/Makefile
+++ b/Makefile
@@ -27,7 +27,6 @@ SC_EXCLUDE := \
 	-e SC2034 \
 	-e SC2035 \
 	-e SC2046 \
-	-e SC2053 \
 	-e SC2086 \
 	-e SC2089 \
 	-e SC2090 \
diff --git a/dim b/dim
index cff5135cd0de..2cf0a769bf47 100755
--- a/dim
+++ b/dim
@@ -257,7 +257,7 @@ function branch_to_repo # branch
 		local repo branch override
 		read repo branch override <<< $conf
 
-		if [[ $branch == $1 ]] ; then
+		if [[ "$branch" == "$1" ]] ; then
 			echo $repo
 		fi
 	done
-- 
2.1.4



More information about the Intel-gfx mailing list