[Intel-gfx] [PATCH 2/4] drm/i915: Check for id==PLANE_CURSOR instead of type==DRM_PLANE_TYPE_CURSOR

Ville Syrjälä ville.syrjala at linux.intel.com
Fri Mar 17 20:01:05 UTC 2017


On Fri, Mar 17, 2017 at 07:54:30PM +0000, Chris Wilson wrote:
> On Fri, Mar 03, 2017 at 05:19:26PM +0200, ville.syrjala at linux.intel.com wrote:
> > From: Ville Syrjälä <ville.syrjala at linux.intel.com>
> > 
> > The VLV/CHV watermark calculation is really interested in the hardware
> > plane type rather than the plane type (which is more of a software
> > concept). Let's check plane->id rather plane->type.
> > 
> > No functional changes.
> 
> When will they differ? Is this for multipurpose planes, such as a sprite
> that we treat as a cursor for simplicity?

Yeah. Currently they never differ, but just in case someone ever decides
to break that relationship I figured it's better to be clear on which kind
of hardware plane we're dealing with.

-- 
Ville Syrjälä
Intel OTC


More information about the Intel-gfx mailing list