[Intel-gfx] [PATCH] drm/i915: Correct error handling for i915_gem_object_create_from_data()
Chris Wilson
chris at chris-wilson.co.uk
Fri Mar 17 20:53:17 UTC 2017
i915_gem_object_create_from_data() always returns and error pointer on
failure, there is no need to check against NULL.
Signed-off-by: Chris Wilson <chris at chris-wilson.co.uk>
---
drivers/gpu/drm/i915/intel_uc.c | 4 ++--
1 file changed, 2 insertions(+), 2 deletions(-)
diff --git a/drivers/gpu/drm/i915/intel_uc.c b/drivers/gpu/drm/i915/intel_uc.c
index 86530c92337a..d15a7d9d4eb0 100644
--- a/drivers/gpu/drm/i915/intel_uc.c
+++ b/drivers/gpu/drm/i915/intel_uc.c
@@ -377,8 +377,8 @@ void intel_uc_prepare_fw(struct drm_i915_private *dev_priv,
uc_fw->major_ver_wanted, uc_fw->minor_ver_wanted);
obj = i915_gem_object_create_from_data(dev_priv, fw->data, fw->size);
- if (IS_ERR_OR_NULL(obj)) {
- err = obj ? PTR_ERR(obj) : -ENOMEM;
+ if (IS_ERR(obj)) {
+ err = PTR_ERR(obj);
goto fail;
}
--
2.11.0
More information about the Intel-gfx
mailing list