[Intel-gfx] [PATCH 4/8] dim: silence shellcheck warning about sourced files

Jani Nikula jani.nikula at intel.com
Tue Mar 21 10:14:30 UTC 2017


Silence shellcheck SC1090: Can't follow non-constant source. Use a
directive to specify location.

Shellcheck is capable of checking the sourced files too, but only if the
source is at a constant location.

Signed-off-by: Jani Nikula <jani.nikula at intel.com>
---
 dim | 4 +++-
 1 file changed, 3 insertions(+), 1 deletion(-)

diff --git a/dim b/dim
index 048b5f0f8345..0fe125335a67 100755
--- a/dim
+++ b/dim
@@ -38,7 +38,8 @@ set -e
 # dim configuration file
 DIM_CONFIG=${DIM_CONFIG:-$HOME/.dimrc}
 if [ -r $DIM_CONFIG ]; then
-    . $DIM_CONFIG
+	# shellcheck source=/dev/null
+	. $DIM_CONFIG
 fi
 
 # prefix for repo directories
@@ -98,6 +99,7 @@ function read_integration_config
 	declare -g -a drm_tip_config
 
 	if [ -r $DIM_PREFIX/drm-rerere/$integration_config ]; then
+		# shellcheck source=/dev/null
 		source $DIM_PREFIX/drm-rerere/$integration_config
 	fi
 
-- 
2.1.4



More information about the Intel-gfx mailing list