[Intel-gfx] [PATCH 04/12] drm/i915/guc: The Additional Data Struct (ADS) should get enabled together with GuC submission

[Ceraolo Spurio, Daniele]

On 3/21/2017 2:02 AM, Oscar Mateo wrote:
> It's mandatory and it gets created if and only if GuC submission is enabled, so that should be
> the condition for informing the GuC about it.

This is true now, but GuC might actually require the ADS even if GuC 
submission is disabled, depending on the features being used. In the 
future we might therefore want to gate ADS logic based on the value of 
guc_loading instead of guc_submission.

This change is coherent with the current flow and makes things cleaner, so:

Reviewed-by: Daniele Ceraolo Spurio <daniele.ceraolospurio at intel.com>

>
> Also s/guc_addon_create/guc_ads_create and s/guc_addon_destroy/guc_ads_destroy and, while
> at it, add an explanation of what things go inside the ADS object.
>
> Cc: Daniele Ceraolo Spurio <daniele.ceraolospurio at intel.com>
> Cc: Joonas Lahtinen <joonas.lahtinen at linux.intel.com>
> Signed-off-by: Oscar Mateo <oscar.mateo at intel.com>