[Intel-gfx] [PATCH 2/2] drm/i915: Fix SKL cursor watermarks

Maarten Lankhorst maarten.lankhorst at linux.intel.com
Wed Mar 22 09:01:13 UTC 2017


Op 14-03-17 om 16:10 schreef ville.syrjala at linux.intel.com:
> From: Ville Syrjälä <ville.syrjala at linux.intel.com>
>
> Use intel_wm_plane_visible() to determine cursor visibility for SKL+
> also. Previously SKL+ would check the actual visibility which now
> conflicts with the assumptions in intel_legacy_cursor_update().
>
> We also change SKL+ to compute the cursor watermarks based on the
> unclipped cursor size, just as we do on all the other platforms.
> Using the clipped size could now result in garbage results.
>
> Testcase: igt/kms_chv_cursor_fail
> Fixes: a5509abda48e ("drm/i915: Fix legacy cursor vs. watermarks for ILK-BDW")
> Bugzilla: https://bugs.freedesktop.org/show_bug.cgi?id=100195
> Signed-off-by: Ville Syrjälä <ville.syrjala at linux.intel.com>
For patch 1 & 2:

Reviewed-by: Maarten Lankhorst <maarten.lankhorst at linux.intel.com>

Should be the right way to fix it. :)



More information about the Intel-gfx mailing list