[Intel-gfx] [PATCH 01/12] drm/i915/guc: Sanitize GuC client initialization

[Oscar Mateo]

On 03/22/2017 02:28 AM, Joonas Lahtinen wrote:
> It's a good practice to use "git am" to apply the original patch and
> then "git commit --amend" to it, so that the "From: " field stays
> intact. Or use git commit --amend --author="John Doe <foo at bar.org>" but
> that is more prone to typos.
>
> On ti, 2017-03-21 at 02:02 -0700, Oscar Mateo wrote:
>> Started adding proper teardown to guc_client_alloc, ended up removing
>> quite a few dead ends where errors communicating with the GuC were
>> silently ignored. There also seemed to be quite a few erronous
>> teardown actions performed in case of an error (ordering wrong).
>>
>> v2:
>>    - Increase function symmetry/proximity (Michal/Daniele)
>>    - Fix __reserve_doorbell accounting for high priority (Daniele)
>>    - Call __update_doorbell_desc! (Daniele)
>>    - Isolate __guc_{,de}allocate_doorbell (Michal/Daniele)
>>
>> v3:
>>    - "Select" a cacheline is a more accurate verb than "reserve" (Daniele).
>>    - We cannot update & create the doorbell without reserving it first, so
>>      move the whole doorbell creation for execbuf_client to the submission
>>      enable (Oscar).i
>>    - Add a fixme for ignoring possible doorbell destroy errors.
>>
>> v4:
>>    - Remove comment about is_high_priority (Daniele)
>>    - Debug message typo (Daniele)
>>    - Reuse __get_doorbell in more places (Daniele)
>>    - Do not do arithmetic on void pointers (Daniele)
>>    - Add comment to __reset_doorbell (Daniele)
>>
>> Signed-off-by: Joonas Lahtinen <joonas.lahtinen at linux.intel.com>
>> Cc: Michal Wajdeczko <michal.wajdeczko at intel.com>
>> Cc: Arkadiusz Hiler <arkadiusz.hiler at intel.com>
>> Cc: Tvrtko Ursulin <tvrtko.ursulin at intel.com>
>> Cc: Chris Wilson <chris at chris-wilson.co.uk>
>> Reviewed-by: Daniele Ceraolo Spurio <daniele.ceraolospurio at intel.com>
>> Signed-off-by: Oscar Mateo <oscar.mateo at intel.com>
> The R-b should probably be after S-o-b if it was to last version.
>
> Regards, Joonas
My bad. I have spent too much time without using Git I'm like wicked 
rusty (you have probably noticed other weird things I've done, like 
sending the last series without the word "PATCH" or sending this one 
without proper versions in the subject). I'll fix those things and resubmit.
Thanks,
Oscar