[Intel-gfx] [PATCH v2 2/5] drm/i915: Skip unused fw_domains

[Chris Wilson]

On Thu, Mar 23, 2017 at 11:36:53AM +0200, Mika Kuoppala wrote:
> Chris Wilson <chris at chris-wilson.co.uk> writes:
> > @@ -1253,9 +1269,9 @@ static void intel_uncore_fw_domains_init(struct drm_i915_private *dev_priv)
> >  			       FORCEWAKE_MT, FORCEWAKE_MT_ACK);
> >  
> >  		spin_lock_irq(&dev_priv->uncore.lock);
> > -		fw_domains_get_with_thread_status(dev_priv, FORCEWAKE_ALL);
> > +		fw_domains_get_with_thread_status(dev_priv, FORCEWAKE_RENDER);
> 
> Well we are skipping here the unused ones so I guess it fits
> to the commit desc.

This patch added the bug on to catch use with an invalid fw_domain (that
would have just been iterated over previously). I suppose I could have
split this chunk into a prep patch...

"In the next patch we will begin to sanity check that we do not attempt
to obtain the forcewake on an unsupport domain. However, that is exactly
what we do during our actual initialisation of fw_domains - rectify it
before it explodes."
-Chris

-- 
Chris Wilson, Intel Open Source Technology Centre