[Intel-gfx] [PATCH] drm/i915: Actually pass the reclaim gfp_t along to shmemfs!

Jani Nikula jani.nikula at linux.intel.com
Thu Mar 23 12:37:17 UTC 2017


On Thu, 23 Mar 2017, Chris Wilson <chris at chris-wilson.co.uk> wrote:
> On Thu, Mar 23, 2017 at 09:29:47AM +0200, Joonas Lahtinen wrote:
>> On ke, 2017-03-22 at 22:34 +0000, Chris Wilson wrote:
>> > Words cannot describe the embarrassment at creating a new gfp_t relaim to
>> > only prevent the oomkiller but allow direct|kswapd reclaim, and then not
>> > use it in the shmem_read_mapping_page_gfp().
>> > 
>> > Fixes: 24f8e00a8a2e ("drm/i915: Prefer to report ENOMEM rather than incur the oom for gfx allocations")
>> > Signed-off-by: Chris Wilson <chris at chris-wilson.co.uk>
>> > Cc: Joonas Lahtinen <joonas.lahtinen at linux.intel.com>
>> > Cc: Daniel Vetter <daniel.vetter at ffwll.ch>
>> 
>> Reviewed-by: Joonas Lahtinen <joonas.lahtinen at linux.intel.com>
>
> Thanks for not being smug, pushed.

He can't afford to be, he reviewed the commit being fixed! ;)

BR,
Jani.

-- 
Jani Nikula, Intel Open Source Technology Center


More information about the Intel-gfx mailing list