[Intel-gfx] [PATCH 1/2] drm/i915: Disable MI_SET_CONTEXT psmi w/a for bdw

Chris Wilson chris at chris-wilson.co.uk
Fri Mar 24 17:11:28 UTC 2017


On Fri, Mar 24, 2017 at 05:01:56PM +0100, Michał Winiarski wrote:
> On Fri, Mar 24, 2017 at 03:17:23PM +0000, Chris Wilson wrote:
> > The current w/a for the gen7 psmi related hangs doesn't apply to bdw, so
> > disable it if using bdw ringbuffer submission.
> > 
> > Signed-off-by: Chris Wilson <chris at chris-wilson.co.uk>
> > ---
> >  drivers/gpu/drm/i915/i915_gem_context.c | 2 +-
> >  1 file changed, 1 insertion(+), 1 deletion(-)
> > 
> > diff --git a/drivers/gpu/drm/i915/i915_gem_context.c b/drivers/gpu/drm/i915/i915_gem_context.c
> > index e8dc3e74c093..68dc81aee2f1 100644
> > --- a/drivers/gpu/drm/i915/i915_gem_context.c
> > +++ b/drivers/gpu/drm/i915/i915_gem_context.c
> > @@ -660,7 +660,7 @@ mi_set_context(struct drm_i915_gem_request *req, u32 flags)
> >  	enum intel_engine_id id;
> >  	const int num_rings =
> >  		/* Use an extended w/a on ivb+ if signalling from other rings */
> 
> The comment also needs updating, we're only using extended w/a (not just
> disabling arbitration) for gen7.
> 
> With that:
> 
> Reviewed-by: Michał Winiarski <michal.winiarski at intel.com>

Tweaked and applied. Now I can delete working code in good conscience!
-Chris

-- 
Chris Wilson, Intel Open Source Technology Centre


More information about the Intel-gfx mailing list