[Intel-gfx] [PATCH v2 5/5] drm/i915: Add more OA configs for BDW, CHV, SKL + BXT

Matthew Auld matthew.william.auld at gmail.com
Mon Mar 27 18:16:47 UTC 2017


On 03/23, Robert Bragg wrote:
> These are auto generated from an XML description of metric sets,
> currently maintained in gputop, ref:
> 
>  https://github.com/rib/gputop
>  > gputop-data/oa-*.xml
>  > scripts/i915-perf-kernelgen.py
> 
>  $ make -C gputop-data -f Makefile.xml
> 
> Signed-off-by: Robert Bragg <robert at sixbynine.org>
> ---

<SNIP>

>  int i915_oa_select_metric_set_bdw(struct drm_i915_private *dev_priv)
>  {
> -	dev_priv->perf.oa.mux_regs = NULL;
> -	dev_priv->perf.oa.mux_regs_len = 0;
> -	dev_priv->perf.oa.b_counter_regs = NULL;
> -	dev_priv->perf.oa.b_counter_regs_len = 0;
> -	dev_priv->perf.oa.flex_regs = NULL;
> -	dev_priv->perf.oa.flex_regs_len = 0;
> +	dev_priv->perf.oa.mux_regs = NULL;
> +	dev_priv->perf.oa.mux_regs_len = 0;
> +	dev_priv->perf.oa.b_counter_regs = NULL;
> +	dev_priv->perf.oa.b_counter_regs_len = 0;
> +	dev_priv->perf.oa.flex_regs = NULL;
> +	dev_priv->perf.oa.flex_regs_len = 0;
What changed? I can't tell from the diff...

Otherwise assuming you re-spin with the DRM_DEBUG changes:
Reviewed-by: Matthew Auld <matthew.auld at intel.com>



More information about the Intel-gfx mailing list