[Intel-gfx] [PATCH v5 15/18] drm/i915: Watchdog timeout: IRQ handler for gen8+

[Chris Wilson]

On Mon, Mar 27, 2017 at 02:48:42PM -0700, Michel Thierry wrote:
> 
> 
> On 25/03/17 02:26, Chris Wilson wrote:
> >On Fri, Mar 24, 2017 at 06:30:07PM -0700, Michel Thierry wrote:
> >>diff --git a/drivers/gpu/drm/i915/intel_ringbuffer.h b/drivers/gpu/drm/i915/intel_ringbuffer.h
> >>index e8faf2c34c97..fffe69f5aed2 100644
> >>--- a/drivers/gpu/drm/i915/intel_ringbuffer.h
> >>+++ b/drivers/gpu/drm/i915/intel_ringbuffer.h
> >>@@ -128,6 +128,7 @@ struct intel_instdone {
> >> struct intel_engine_hangcheck {
> >> 	u64 acthd;
> >> 	u32 seqno;
> >>+	u32 last_watchdog_seqno;
> >
> >Just watchdog will be enough for its meaning to be clear.
> 
> watchdog or watchdog_seqno?

Here, intel_engine_hangcheck.watchdog is unique enough for it not to be
confusing. If we grow more interesting bits for the watchdog, we break
it out into its own substruct. Maybe we should task Mika with filling in
some kerneldoc for struct intel_engine_hangcheck?
-Chris

-- 
Chris Wilson, Intel Open Source Technology Centre