[Intel-gfx] [RFC 1/4] drm/i915/scheduler: Remember request priority throughout its lifetime

[Chris Wilson]

On Tue, Mar 28, 2017 at 08:00:26PM +0200, Michał Winiarski wrote:
> Since request can be unsubmitted, we need to avoid overriding its priority
> during submission. Otherwise we won't be able to resubmit it with
> correct priority.
> 
> Cc: Chris Wilson <chris at chris-wilson.co.uk>
> Cc: Joonas Lahtinen <joonas.lahtinen at linux.intel.com>
> Cc: Tvrtko Ursulin <tvrtko.ursulin at intel.com>
> Signed-off-by: Michał Winiarski <michal.winiarski at intel.com>
> ---
>  drivers/gpu/drm/i915/i915_guc_submission.c | 1 -
>  drivers/gpu/drm/i915/intel_lrc.c           | 1 -
>  2 files changed, 2 deletions(-)
> 
> diff --git a/drivers/gpu/drm/i915/i915_guc_submission.c b/drivers/gpu/drm/i915/i915_guc_submission.c
> index 6193ad7..082f8ae 100644
> --- a/drivers/gpu/drm/i915/i915_guc_submission.c
> +++ b/drivers/gpu/drm/i915/i915_guc_submission.c
> @@ -692,7 +692,6 @@ static bool i915_guc_dequeue(struct intel_engine_cs *engine)
>  		rb = rb_next(rb);
>  		rb_erase(&rq->priotree.node, &engine->execlist_queue);
>  		RB_CLEAR_NODE(&rq->priotree.node);
> -		rq->priotree.priority = INT_MAX;

This still breaks execlists_schedule().
-Chris

-- 
Chris Wilson, Intel Open Source Technology Centre