[Intel-gfx] [PATCH] drm/i915: Drop verbose and archaic "ring" from our internal engine names
Joonas Lahtinen
joonas.lahtinen at linux.intel.com
Thu Mar 30 12:23:25 UTC 2017
On ke, 2017-03-29 at 23:04 +0100, Chris Wilson wrote:
> We pretty print the name of an engine in several places, mostly for
> debug, but also in the GPU hang report. Using "ring" in the name is
> archaic (we call those engines now to differentiate them from the
> multiple rings of commands we execute on each engine), quite verbose and
> often tautological. We run out of room in our GPU hang report for
> instance if we have more than a couple of engines hung simultaneously.
> Bit the bullet and update the strings to reflect the common internal names.
>
> Signed-off-by: Chris Wilson <chris at chris-wilson.co.uk>
<SNIP>
> @@ -36,7 +36,7 @@ static const struct engine_info {
> int (*init_execlists)(struct intel_engine_cs *engine);
> } intel_engines[] = {
> [RCS] = {
> - .name = "render ring",
> + .name = "rcs",
> .uabi_id = I915_EXEC_RENDER,
> .hw_id = RCS_HW,
Lift the .hw_id after .name now that it's the more closely related.
With that applied to each;
Reviewed-by: Joonas Lahtinen <joonas.lahtinen at linux.intel.com>
Regards, Joonas
--
Joonas Lahtinen
Open Source Technology Center
Intel Corporation
More information about the Intel-gfx
mailing list