[Intel-gfx] [PATCH] drm/i915/GLK/HuC: Load HuC on GLK

[Joonas Lahtinen]

On ke, 2017-03-29 at 10:54 +0300, Jani Nikula wrote:
> > On Wed, 29 Mar 2017, John Spotswood <john.a.spotswood at intel.com> wrote:
> > 
> > On Tue, 2017-03-21 at 17:29 -0700, Anusha Srivatsa wrote:
> > > 
> > > +#define I915_GLK_HUC_UCODE HUC_FW_PATH(glk, GLK_HUC_FW_MAJOR, \
> > > +	GLK_HUC_FW_MINOR, GLK_BLD_NUM)
> > 
> > I think you need a line after this #define that says the following:
> >    MODULE_FIRMWARE(I915_GLK_HUC_UCODE);
> 
> The rule is, we'll only add the MODULE_FIRMWARE annotation *after* the
> firmware blob has hit the linux-firmware repository.

Maybe we should document the expectation here too?

Regards, Joonas
-- 
Joonas Lahtinen
Open Source Technology Center
Intel Corporation