[Intel-gfx] [PATCH] drm/i915/gvt: disable GVT-g if host GuC submission is enabled

[Dong, Chuanxiao]

> -----Original Message-----
> From: Joonas Lahtinen [mailto:joonas.lahtinen at linux.intel.com]
> Sent: Friday, May 5, 2017 4:55 PM
> To: Zhenyu Wang <zhenyuw at linux.intel.com>; Dong, Chuanxiao
> <chuanxiao.dong at intel.com>; Daniel Vetter <daniel.vetter at ffwll.ch>
> Cc: intel-gfx at lists.freedesktop.org; intel-gvt-dev at lists.freedesktop.org
> Subject: Re: [Intel-gfx] [PATCH] drm/i915/gvt: disable GVT-g if host GuC
> submission is enabled
> 
> + Daniel
> 
> On ke, 2017-05-03 at 16:36 +0800, Zhenyu Wang wrote:
> > On 2017.05.02 16:58:31 +0800, Chuanxiao Dong wrote:
> > >
> > > Currently GVT-g cannot work properly when host GuC submission is
> > > enabled, so disable GVT in this case.
> > >
> > > Cc: Zhenyu Wang <zhenyuw at linux.intel.com>
> > > Signed-off-by: Chuanxiao Dong <chuanxiao.dong at intel.com>
> 
> <SNIP>
> 
> > > @@ -84,6 +84,11 @@ int intel_gvt_init(struct drm_i915_private
> *dev_priv)
> > >  		goto bail;
> > >  	}
> > >
> > > +	if (i915.enable_guc_submission) {
> > > +		DRM_INFO("GPU guest virtualisation [GVT-g] disabled due to
> > > +enabled GuC submission [i915.enable_guc_submission module
> > > +parameter]\n");
> 
> Guest module parameter is not the correct way of detetecting if host has
> GuC submission enabled. And even if it was, the message is overly verbose
> (and it'll be incorrect once i915.enable_guc_submission defaults to
> something else than zero).

Hi Joonas,

How about just to say " DRM_INFO("GPU guest virtualisation [GVT-g] disabled due to enabled GuC submission\n");"

Thanks
Chuanxiao

> 
> > > +		goto bail;
> > > +	}
> > > +
> > >  	/*
> > >  	 * We're not in host or fail to find a MPT module, disable GVT-g
> > >  	 */
> > > --
> >
> > Applied, thanks!
> 
> The original patch should've included at least some Cc's, or wait being
> merged through drm-tip as it's not int drm/i915/gvt directory at all (unlike
> the message states).
> 
> The patch should be reverted for being incorrect.
> 
> Regards, Joonas
> --
> Joonas Lahtinen
> Open Source Technology Center
> Intel Corporation