[Intel-gfx] [PATCH v3 2/3] drm/i915/guc: Make scratch register base and count flexible

Jani Nikula jani.nikula at linux.intel.com
Mon May 8 12:07:57 UTC 2017


On Mon, 08 May 2017, Joonas Lahtinen <joonas.lahtinen at linux.intel.com> wrote:
> PS. I personally don't like the enum typed bitfields, but that's an
> another discussion (that's been had in the past).

I'm with you on this one. It's semi-okay to define the bits as enums,
but IMO a variable of an enum type should only ever be used to hold the
enumerated values. Too bad C doesn't give us strong type checking for
enums.

BR,
Jani.


-- 
Jani Nikula, Intel Open Source Technology Center


More information about the Intel-gfx mailing list